Skip to content

[PW_SID:1070415] [v1,1/2] perf build: Remove libunwind support#1655

Open
linux-riscv-bot wants to merge 2 commits intoworkflowfrom
pw1070415
Open

[PW_SID:1070415] [v1,1/2] perf build: Remove libunwind support#1655
linux-riscv-bot wants to merge 2 commits intoworkflowfrom
pw1070415

Conversation

@linux-riscv-bot
Copy link

PR for series 1070415 applied to workflow

Name: [v1,1/2] perf build: Remove libunwind support
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1070415
Version: 1

libunwind support is deprecated and libdw is preferred for DWARF unwinding.
Remove the libunwind configuration from Makefile.config, and delete the
associated source files and architecture-specific support code.

Update the DWARF post-unwind logic to rely solely on libdw. Clean up
the HAVE_LIBUNWIND_SUPPORT and CONFIG_LIBUNWIND references across
the codebase, including the unwind_libunwind_ops structure.

Signed-off-by: Ian Rogers <irogers@google.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Libunwind support has been removed from perf, so the feature tests
used to detect its presence are no longer needed. Remove the
test-libunwind-*.c files and their references in the feature Makefile.

Signed-off-by: Ian Rogers <irogers@google.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1008.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1372.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.20 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 6.88 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#347: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 552 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 664ae5142b76 ("perf build: Remove libunwind support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 552 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.62 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
kdoc
Desc: Detects for kdoc errors
Duration: 1.98 seconds
Result: ERROR
Output:

Checking the tree before the patch
Warning: tools/perf/builtin-check.c:98 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * check whether "feature" is built-in with perf
Warning: tools/perf/builtin-check.c:135 function parameter 'argc' not described in 'subcommand_feature'
Warning: tools/perf/builtin-check.c:135 function parameter 'argv' not described in 'subcommand_feature'
Warning: tools/perf/builtin-check.c:135 expecting prototype for Usage(). Prototype was for subcommand_feature() instead
Warning: tools/perf/util/dso.h:216 struct member 'maj' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'min' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino_generation' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'maj' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'min' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino_generation' not described in 'dso_id'
Checking the tree with the patch
Error: Cannot find file tools/perf/arch/arm/util/unwind-libunwind.c
Error: Cannot find file tools/perf/arch/arm64/util/unwind-libunwind.c
Error: Cannot find file tools/perf/arch/loongarch/util/unwind-libunwind.c
Error: Cannot find file tools/perf/arch/mips/util/unwind-libunwind.c
Error: Cannot find file tools/perf/arch/powerpc/util/unwind-libunwind.c
Error: Cannot find file tools/perf/arch/x86/util/unwind-libunwind.c
Warning: tools/perf/builtin-check.c:97 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
 * check whether "feature" is built-in with perf
Warning: tools/perf/builtin-check.c:134 function parameter 'argc' not described in 'subcommand_feature'
Warning: tools/perf/builtin-check.c:134 function parameter 'argv' not described in 'subcommand_feature'
Warning: tools/perf/builtin-check.c:134 expecting prototype for Usage(). Prototype was for subcommand_feature() instead
Warning: tools/perf/util/dso.h:216 struct member 'maj' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'min' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino_generation' not described in 'dso_id'
Error: Cannot find file tools/perf/util/libunwind/arm64.c
Error: Cannot find file tools/perf/util/libunwind/x86_32.c
Error: Cannot find file tools/perf/util/unwind-libunwind-local.c
Error: Cannot find file tools/perf/util/unwind-libunwind.c
Warning: tools/perf/util/dso.h:216 struct member 'maj' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'min' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino' not described in 'dso_id'
Warning: tools/perf/util/dso.h:216 struct member 'ino_generation' not described in 'dso_id'
Errors and warnings before: 13 this patch: 23
New warnings added
1c1,7
< Warning: tools/perf/builtin-check.c:98 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
---
> Error: Cannot find file tools/perf/arch/arm/util/unwind-libunwind.c
> Error: Cannot find file tools/perf/arch/arm64/util/unwind-libunwind.c
> Error: Cannot find file tools/perf/arch/loongarch/util/unwind-libunwind.c
> Error: Cannot find file tools/perf/arch/mips/util/unwind-libunwind.c
> Error: Cannot find file tools/perf/arch/powerpc/util/unwind-libunwind.c
> Error: Cannot find file tools/perf/arch/x86/util/unwind-libunwind.c
> Warning: tools/perf/builtin-check.c:97 This comment starts with '/**', but isn't a kernel-doc comment. Refer to Documentation/doc-guide/kernel-doc.rst
3,5c9,11
< Warning: tools/perf/builtin-check.c:135 function parameter 'argc' not described in 'subcommand_feature'
< Warning: tools/perf/builtin-check.c:135 function parameter 'argv' not described in 'subcommand_feature'
< Warning: tools/perf/builtin-check.c:135 expecting prototype for Usage(). Prototype was for subcommand_feature() instead
---
> Warning: tools/perf/builtin-check.c:134 function parameter 'argc' not described in 'subcommand_feature'
> Warning: tools/perf/builtin-check.c:134 function parameter 'argv' not described in 'subcommand_feature'
> Warning: tools/perf/builtin-check.c:134 expecting prototype for Usage(). Prototype was for subcommand_feature() instead
9a16,19
> Error: Cannot find file tools/perf/util/libunwind/arm64.c
> Error: Cannot find file tools/perf/util/libunwind/x86_32.c
> Error: Cannot find file tools/perf/util/unwind-libunwind-local.c
> Error: Cannot find file tools/perf/util/unwind-libunwind.c
Per-file breakdown


@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
module-param
Desc: Detect module_param changes
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v1,1/2] perf build: Remove libunwind support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.32 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 138.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1006.64 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1371.07 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.58 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#82: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 43 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 59493cc49456 ("tools build: Remove libunwind feature tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 0 checks, 43 lines checked
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
kdoc
Desc: Detects for kdoc errors
Duration: 1.87 seconds
Result: ERROR
Output:

Checking the tree before the patch
Checking the tree with the patch
Error: Cannot find file tools/build/feature/test-libunwind-aarch64.c
Error: Cannot find file tools/build/feature/test-libunwind-arm.c
Error: Cannot find file tools/build/feature/test-libunwind-debug-frame-aarch64.c
Error: Cannot find file tools/build/feature/test-libunwind-debug-frame-arm.c
Error: Cannot find file tools/build/feature/test-libunwind-debug-frame.c
Error: Cannot find file tools/build/feature/test-libunwind-x86.c
Error: Cannot find file tools/build/feature/test-libunwind-x86_64.c
Error: Cannot find file tools/build/feature/test-libunwind.c
Errors and warnings before: 0 this patch: 8
New warnings added
0a1,8
> Error: Cannot find file tools/build/feature/test-libunwind-aarch64.c
> Error: Cannot find file tools/build/feature/test-libunwind-arm.c
> Error: Cannot find file tools/build/feature/test-libunwind-debug-frame-aarch64.c
> Error: Cannot find file tools/build/feature/test-libunwind-debug-frame-arm.c
> Error: Cannot find file tools/build/feature/test-libunwind-debug-frame.c
> Error: Cannot find file tools/build/feature/test-libunwind-x86.c
> Error: Cannot find file tools/build/feature/test-libunwind-x86_64.c
> Error: Cannot find file tools/build/feature/test-libunwind.c
Per-file breakdown


@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v1,2/2] tools build: Remove libunwind feature tests"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants